Support closing keywords with URL references #36221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, closing keywords (closes, fixes, etc.) only worked with short references like `closes go-gitea#123` or `closes org/repo#123`. This commit adds support for closing keywords with full URL references in markdown links, such as: - `Closes [this issue](https://gitea.io/user/repo/issues/123)` - `Fixes [go-gitea#456](https://gitea.io/org/project/issues/456)` The fix works by: 1. Passing the original content to findAllIssueReferencesBytes 2. When processing URL links, finding the URL position in original content 3. For markdown links [text](url), finding the opening bracket position 4. Using that position to detect closing keywords before the link Fixes go-gitea#27549
GiteaBot
added
the
lgtm/need 2
Member
|
Could you also add test cases for bare URL? I'm pretty sure they already work, but good add more tests: |
Added test coverage for bare URLs with closing keywords: - Fixes https://... - Fixes: https://... - Closes https://... - Closes: https://... As suggested by @silverwind
Contributor
Author
|
@silverwind Added test cases for bare URLs with closing keywords. All tests passing. |
silverwind
approved these changes
Dec 24, 2025
GiteaBot
added
lgtm/need 1
lunny
reviewed
Dec 24, 2025
Contributor
Author
|
When idx is 0, it means the URL is at the very beginning of the content. In that case, there's nothing before it where a closing keyword like "Closes" or "Fixes" could exist. The findActionKeywords function looks at content[:start], so if start is 0, it searches an empty slice and returns XRefActionNone anyway. I can change it to idx >= 0 if you prefer - the result would be the same but maybe clearer to read. Let me know. |
Contributor
Author
|
/test-all |
lunny
approved these changes
Dec 25, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
changed the title
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 29, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Use gitrepo's push function (go-gitea#36245) Support closing keywords with URL references (go-gitea#36221) Add an option to automatically verify SSH keys from LDAP (go-gitea#35927) remove nolint (go-gitea#36252) Use the requested host for LFS links (go-gitea#36242)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for closing keywords (
closes,fixes,reopens, etc.) with full URL references in markdown links.Before:
closes #123✅ workscloses org/repo#123✅ worksCloses [this issue](https://gitea.io/user/repo/issues/123)❌ didn't workFixes [#456](https://gitea.io/org/project/issues/456)❌ didn't workAfter:
All of the above now work correctly.
Problem
When users reference issues using full URLs in markdown links (e.g.,
Closes [this issue](https://gitea.io/user/repo/issues/123)), the closing keywords were not detected. This was because the URL processing code explicitly stated:// Note: closing/reopening keywords not supported with URLsBoth methods of writing the reference render the same in the UI, so users expected the closing keywords to behave the same.
Solution
The fix works by:
findAllIssueReferencesBytes[text](url), finding the opening bracket[positionTesting
Added test cases for:
Closes [this issue](url)- single URL with closing keywordThis fixes [#456](url)- keyword in middle of textReopens [PR](url)- reopen keyword with pull request URLAll existing tests continue to pass.
Fixes #27549